search

Poeschl / Hassio-Addons

The repository for my Home Assistant Supervisor Add-ons.
Apache License 2.0
298 stars 89 forks source link

[syncthing] Fix #340 #457

Closed salim-b closed 3 months ago

salim-b commented 5 months ago

Beware that this PR is untested. Fixes #340.

I'm unsure whether it's fine to do it like this. Maybe the main syncthing invocation (syncthing --gui-address="$ip:8384" --no-browser) must come last in the S6 run script for HA to be able to detect when the add-on crashes (and automatically restart it if desired)? In that case I wouldn't know how to run syncthing cli config gui insecure-admin-access set true since syncthing cli commands only work when Syncthing is already running...

Poeschl commented 3 months ago

I took your changes add embedded then into s6 ;) a5692259062dcad4b37373ce26a9052d604893cf