Tablet support for annotator editor

[codyml]

Changed the button to a tab, made the tab more UI-friendly.

[mwidner]

Hi Cody,

I know you're off, but quick question: did you add a new menu block for superfish? There's a conflict around superfish_smallbp_1, which I don't have, so I'd like to recreate it so I can merge this in. Thanks.

[codyml]

Hi,

Just got back, I'll be in tomorrow! I believe superfish_smallbp_1 is my updated setting for the cutoff for when superfish turns to the mobile menu instead of the full blocks; it should be set to something like 960.

Cody

On Wed, Sep 2, 2015 at 8:15 PM, Michael Widner notifications@github.com wrote:

Hi Cody,

I know you're off, but quick question: did you add a new menu block for superfish? There's a conflict around superfish_smallbp_1, which I don't have, so I'd like to recreate it so I can merge this in. Thanks.

— Reply to this email directly or view it on GitHub https://github.com/LacunaStories/Drupal-Master/pull/108#issuecomment-137312404 .

[mwidner]

Great. So is this something I need to create or will the settings in the feature get it automatically, you think? Thanks.

[codyml]

I'm not quite sure I understand – I exported the feature so it gets re-set automatically, right?

On Tue, Sep 8, 2015 at 9:57 AM, Michael Widner notifications@github.com wrote:

Great. So is this something I need to create or will the settings in the feature get it automatically, you think? Thanks.

— Reply to this email directly or view it on GitHub https://github.com/LacunaStories/Drupal-Master/pull/108#issuecomment-138633203 .

[mwidner]

It should. I just haven't had a chance to clear up the scss merge conflict yet, so I haven't been able to test it. Once I get that done, I'll see! Thanks again.

[codyml]

Ok, let me know how I can help!

On Tue, Sep 8, 2015 at 10:10 AM, Michael Widner notifications@github.com wrote:

It should. I just haven't had a chance to clear up the scss merge conflict yet, so I haven't been able to test it. Once I get that done, I'll see! Thanks again.

— Reply to this email directly or view it on GitHub https://github.com/LacunaStories/Drupal-Master/pull/108#issuecomment-138636908 .

[mwidner]

Hey Cody, if you have time, would you do me a favor and break out all the touch-specific SCSS for Annotator into a separate file? The merge resolution, even with good tools, is proving a challenge that would be easy to fix this way. Let me know if you won't have time. Thanks.

[codyml]

Hi,

Sorry, just saw this. I can do that, but in addition to adding some stuff I also changed some of the values to work better on both mobile and desktop. Should I just move everything with media queries or using selectors that are specific to the mobile annotator?

Cody

On Tue, Sep 8, 2015 at 2:53 PM, Michael Widner notifications@github.com wrote:

Hey Cody, if you have time, would you do me a favor and break out all the touch-specific SCSS for Annotator into a separate file? The merge resolution, even with good tools, is proving a challenge that would be easy to fix this way. Let me know if you won't have time. Thanks.

— Reply to this email directly or view it on GitHub https://github.com/LacunaStories/Drupal-Master/pull/108#issuecomment-138715102 .

[codyml]

I just moved everything over – let me know if that helps or if I should try something else!

[mwidner]

Thanks! If that doesn't do it, maybe we can sit down to work on it if you're still around?

On 9/8/15 8:16 PM, Cody M Leff wrote:

I just moved everything over – let me know if that helps or if I should try something else!

— Reply to this email directly or view it on GitHub https://github.com/LacunaStories/Drupal-Master/pull/108#issuecomment-138764961.

[codyml]

Yup, I'm here for a little longer tonight and tomorrow morning thru early afternoon, also thursday and friday!