search

PoeticMediaLab / Lacuna

Lacuna: Digital Annotation for Teaching and Learning
http://www.lacunastories.com
GNU General Public License v2.0
36 stars 20 forks source link

Show comment count on annotator viewer and add easy-comment icon. #19

Closed ranajays closed 9 years ago

mwidner commented 9 years ago

FYI: I made some minor changes to the plugin. I also had to rename the class because there's some problem, which I've run into before, with Annotator plugins that have multi-word camelCased names. It's somewhere in the annotator.module when it's loading ctools plugins, but it's easier just to change the name. :) Nice work.

ranajays commented 9 years ago

Oh, could you tell me what the problems with that are exactly? That's probably what I'm running into for my other comment plugins as well. On Jan 8, 2015 1:44 PM, "Michael Widner" notifications@github.com wrote:

FYI: I made some minor changes to the plugin. I also had to rename the class because there's some problem, which I've run into before, with Annotator plugins that have multi-word camelCased names. It's somewhere in the annotator.module when it's loading ctools plugins, but it's easier just to change the name. :) Nice work.

— Reply to this email directly or view it on GitHub https://github.com/LacunaStories/Drupal-Master/pull/19#issuecomment-69254978 .

mwidner commented 9 years ago

Sure. If you look at all the plugins, you'll see they're named NameAnnotatorPlugin, not NameAnotherNameAnnotatorPlugin. For some reason, "NameAnotherName" turns into "Nameanothername" in the annotator_execute_plugins function in annotator.module, so the plugins named like that don't load. Again, I suspect there's an easy fix so we can name our plugins whatever we want, but I haven't bothered trying.