PoeticMediaLab / Lacuna

Lacuna: Digital Annotation for Teaching and Learning
http://www.lacunastories.com
GNU General Public License v2.0
36 stars 20 forks source link

Character Count Limit #46

Closed hthayko closed 9 years ago

hthayko commented 9 years ago

added hook_update_N for adding a char count limit on user account fields about_me and how_i_learn.

mwidner commented 9 years ago

Hi Hayk,

Thanks for the fix. This is a really nice use of the hook_update_N call, in fact. But, there's already a Drupal module that handles the general case of character limits on fields:

https://www.drupal.org/project/maxlength

For future changes like this, though, I like this approach, though rather than create a custom module for each change, we should roll them all into a single deployment module, as we discussed.

hthayko commented 9 years ago

It's great there is a module specially for this purpose. I will create another pull request using the module.