search

PoeticMediaLab / Lacuna

Lacuna: Digital Annotation for Teaching and Learning
http://www.lacunastories.com
GNU General Public License v2.0
36 stars 20 forks source link

createcourse permissions update #63

Closed tloudon closed 9 years ago

tloudon commented 9 years ago

Hey Mike,

Just, FYI. I'll be pushing several pull requests today. I'm not sure if you want to QA them all at once, but they will be more or less atomic so there shouldn't be any blockers.

This one is just a minor cleanup of the token/access check on the createcourse stuff. I spoke w/ @shirazd (he hasn't replicated the initial issue since he updated w/ the develop branch) and went over the the site w/ multiple users--so I think we should finally be able to put this one to bed. I should be able to create some automated tests pretty quickly if you still have concerns though--just let me know.

Thanks!

mwidner commented 9 years ago

Thanks, Tim. Did you intend to make this PR also include the Peer Group stuff? The menu access on Courses seems to be working right now.

tloudon commented 9 years ago

@mwidner SORRY. I didn't realize I was still adding commits to the PR!

Not sure on the best route for going forward. Most of the Peer Group commits are encapsulated and I did want to show you the js stuff later today on that front just to make sure we are headed in the right direction; but there are some feature updates too. I was trying to sync up my branch and @shirazd branch w/ your develop branch and also sync Shiraz's and mine.

I could just checkout the menu access commit as a different branch and do a PR w/ that and then create another branch w/ the feature changes. Then we could rm this PR. What makes the most sense for you?

Thanks!

mwidner commented 9 years ago

Do you plan to have the peer group stuff all as a single PR anyway?

It'd be good to have the menu changes as a separate PR so I can merge and push right away, while the other stuff is in progress. Otherwise, however you want to group it is fine by me. I just have some broken stuff on the server I'd like to fix. :)

Typed with my thumbs.

On Jun 12, 2015, at 2:16 PM, tloudon notifications@github.com wrote:

@mwidner SORRY. I didn't realize I was still adding commits to the PR!

Not sure on the best route for going forward. Most of the Peer Group commits are encapsulated and I did want to show you the js stuff later today on that front just to make sure we are headed in the right direction; but there are some feature updates too. I was trying to sync up my branch and @shirazd branch w/ your develop branch and also sync Shiraz's and mine.

I could just checkout the menu access commit as a different branch and do a PR w/ that and then create another branch w/ the feature changes. Then we could rm this PR. What makes the most sense for you?

Thanks!

— Reply to this email directly or view it on GitHub.

tloudon commented 9 years ago

closed see #64 for menu fix PR. will open add'l ones for groups, etc. Thanks!