search

PoeticMediaLab / Lacuna

Lacuna: Digital Annotation for Teaching and Learning
http://www.lacunastories.com
GNU General Public License v2.0
36 stars 20 forks source link

site restructure + install profile tweaks #95

Closed shirazd closed 9 years ago

shirazd commented 9 years ago

Hi Mike,

As noted in the chat, there was a conflict with the style sheet. That resolved easily enough but more consequential, and presumably not related to the style sheet changes, it appears to me the markup on the annotator changed, as in there is no styling on the audience or peer group options, and moreover you can't select an audience! I'm thinking maybe Cody reworked the markup there? Note, I reworked the Co-Learners at the js level to become Peer Groups, but I didn't touch the audience markup at all (or any of the markup per se), so it's probably just something upstream as opposed to a bad conflict resolution.

In any case, I thought it would be wiser to send the pull request unmerged so you can see what I mean, just in case the issue is related to the merge itself. Sorry I won't be around to look at this with you. If you want to leave that part out, feel free to look around at all the other stuff other than the annotator (though most of it depends on that, come to think of it) until I get back on Tuesday then I can work it out with yourself/Cody.

Note there was also some styling loss on the menu, though that will be easy to fix. And the only consequence of the lost fitlers file was a small tweak I made to get input field in the Annotator and Course filters in Sewing Kit to go proper width (easy to fix later).

Cheers...

shirazd commented 9 years ago

Oh I should also mention that you definitely want to do a clean profile install for this.