Closed bartelemi closed 6 months ago
Thank you for suggestion however I do not think it is necessary. Our library is only imported in env.py file which is rarely checked by mypy (correct me if I am wrong)
Our library is only imported in env.py file which is rarely checked by mypy (correct me if I am wrong)
Well, mypy checks whatever you ask it to check. I prefer to check everything I can, and without this py.typed
I get a warning on this library. It’s not super important, but if you could add it in the next release it would be nice :)
Our library is only imported in env.py file which is rarely checked by mypy (correct me if I am wrong)
Well, mypy checks whatever you ask it to check. I prefer to check everything I can, and without this
py.typed
I get a warning on this library. It’s not super important, but if you could add it in the next release it would be nice :)
Pretty much this ☝🏻 Without the py.typed file (which is just an empty file in your repo, an indicator), I have to explicitly add this library in the mypy exclude list. It looks like you already add type definitions to your lib, so the only thing to worry about is adding this file and making sure it is shipped in the final package.
These changes are shipped in 1.2.0a1
version. I'll close this issue when next release will be dropped
what.
Since you're declaring types in your codebase, you should add the
py.typed
file to the repository (under thealembic_postgresql_enum
directory) and include it in the distributed package.This is so that people don't have to add your library to mypy ignore list :)
references.
https://peps.python.org/pep-0561/#packaging-type-information