search

Pogify / pogify

Listen to music with your live audience without getting DMCA-striked!
http://www.pogify.net
GNU Affero General Public License v3.0
55 stars 4 forks source link

Feat/club utils #12

Closed jasoneffendi closed 4 years ago

jasoneffendi commented 4 years ago

What do your changes do? Moving secondsToTimeFormat to utils/Formatters.js, added a simple test case, fixed import error during running tests

How did you achieve this? Moving secondsToTimeFormat from Player.jsx to utils/Formatters.js, added Formatters.test.js, and commented out App import in App.test.js

Screenshot Non-visual

Reference your commit and/or a related issue https://github.com/Pogify/pogify/commit/ec313a86bef881335d7b1f52d4fe86cd6866e5a1 https://github.com/Pogify/pogify/commit/67de523c2b23a50c8e60e8a9f327bf7bf18713ce https://github.com/Pogify/pogify/commit/880be90316a6e78e16a196ef38cc603432065d6d

Which maintainer approved you to make this contribution? @BeakerThe1st

Additional Info Null

jeongY-Cho commented 4 years ago

We are starting to establish a file casing scheme. We want to PascalCase jsx / component files and camelCase all other js files. Do you mind renaming to match.

jasoneffendi commented 4 years ago

Updated

jeongY-Cho commented 4 years ago

Thanks for your contribution!