Pogify / pogify

Listen to music with your live audience without getting DMCA-striked!
http://www.pogify.net
GNU Affero General Public License v3.0
55 stars 4 forks source link

Added Dockerfile #61

Closed Venoox closed 4 years ago

Venoox commented 4 years ago

I added Dockerfile for easier development. Later I will also add Dockerfile for pogify-functions and then I will add instructions with example docker compose.

netlify[bot] commented 4 years ago

Deploy request for pogify rejected.

Rejected with commit 4a8c15dfd4685118cbdb055bfa1ba4b2db05ade7

https://docs.netlify.com/configure-builds/environment-variables/#sensitive-variable-policy

jeongY-Cho commented 4 years ago

Hi venoox thanks for contributing. But may i ask what the point of this dockerfile is? If its just copying files into a docker container then running it, its no different than anyone just doing the same on their computer without a container right? Am I missing something?

Venoox commented 4 years ago

I want to make creating dev environment easier by making Dockerfiles for each component and then one docker-compose that builds everything so people that want to contribute can do it easily.

jeongY-Cho commented 4 years ago

But if the docker file only copies files once isn't it then more difficult in this instance specifically. I understand how it can simplify the bootstrapping pogify-functions because of all the setup with the emulator and all but here don't people need to build a new image every time they make a change? At least that's what it looks like since it doesn't expose any of the files to edit? Is there something around this that I don't know about?

Venoox commented 4 years ago

When running the container you can mount a volume and that will make hot reloading possible

jeongY-Cho commented 4 years ago

Whats the process for doing that? Is it just as easy as cloning the repo and running it without a container? Sorry for all the questions im not an expert in docker

Venoox commented 4 years ago

For example like this docker run -p 3000:3000 -v $PWD:/app pogify but if you include all Dockerfiles together in one docker-compose file then it becomes as easy as docker-compose up --build to get the whole system running

jeongY-Cho commented 4 years ago

Cool sounds good to me.