search

PogoFrontier / pogo-web

A real-time multiplayer battling simulator for Pokemon GO. Build a team, find an opponent, then battle it out.
MIT License
13 stars 4 forks source link

Refactor: Migrate static files to Firestore/CDN #12

Closed DeveloperKhan closed 3 years ago

DeveloperKhan commented 3 years ago

The JSON and png assets from {backend}/public/mini and {backend}/public/models should be removed from the backend repository and instead stored in Cloud Firestore.

Requirements

ophidianab commented 3 years ago

What impact would doing so have on someone else self-hosting their own instance of the project? Is that a use case you want to preserve?

DeveloperKhan commented 3 years ago

What impact would doing so have on someone else self-hosting their own instance of the project? Is that a use case you want to preserve?

Oh yeh that is a great thing to consider. Since our image data is straight from Pokemon Showdown (unedited), others can just reference that github repository. I'll update the README about it after this issue is closed. For the Pokemon and move data, I will change the issue description so that those are kept within the static express directory. Not only for people that want to make their own instances, but it also lets us have multiple express instances with different game masters opening up the opportunity for custom games/mods.

DeveloperKhan commented 3 years ago

Probably good to switch to S3 + Cloudfront in the future, but for now it works great!