PoiPoi-Dev / PoiPoi-frontend

MIT License
0 stars 4 forks source link

feat: add test on `/landing` to test Github url and Next middleware rerouting feature #167

Closed DepartureLV closed 6 days ago

DepartureLV commented 1 week ago

Description

add Cypress test for /landing page to test if the href is working as it should. add Cypress test for /landing page to test if mobile and desktop user get rerouted to the right path

Card Link

https://3.basecamp.com/5802516/buckets/37608217/card_tables/cards/7511542655

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist before requesting a review

dominiksakic commented 6 days ago

@DepartureLV the test look good to me. I saw that you added two more dependencies - are these only used for the test? Could we install them as dev dependencies?

DepartureLV commented 6 days ago

@dominiksakic yes, I have moved that into dev dependencies. Can we merge this into development?