PoiPoi-Dev / PoiPoi-frontend

MIT License
1 stars 4 forks source link

Feat/display map #8

Closed J-Ariola closed 5 months ago

J-Ariola commented 5 months ago

Description

On the main page, there is a Map button that moves the user to the Map route. The map container is the size of the screen. The map is centered in Japan.

Card Link

https://3.basecamp.com/5802516/buckets/37608217/card_tables/cards/7440817782

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

No official testing on Jest, but the map can be see from the /map route. Will write tests in another branch

Checklist before requesting a review

DepartureLV commented 5 months ago

LGTM

chadgrover commented 5 months ago

@J-Ariola Just a heads up for the Team:

The NEXT_PUBLIC_ prefix is required when dealing with environment variables in the client. However, this also requires "exposing" the variable to the browser, making it potentially unsafe. Sometimes this can't be helped, though.

https://nextjs.org/docs/app/building-your-application/configuring/environment-variables

If you want to keep that information performant and secure, Vercel recommends fetching data from a server component. Once the data is fetched, you can pass it down as a prop to a client component (if needed.)

https://nextjs.org/docs/app/building-your-application/rendering/composition-patterns

For performance reasons: you're also looking at much faster response times when the frontend and backend server are located in the same data center. 👀