PoiPoi-Dev / PoiPoi-frontend

MIT License
0 stars 4 forks source link

PR | Leaderboardlocalstorage #87

Closed dominiksakic closed 1 month ago

dominiksakic commented 1 month ago

Description

Refactor leaderboard into a CSR component to get access to the username. I used localstorage instead of the usecontext for ooptimization to not fetch. I stored the username only no other data in the localstorage.

When the user logs out the data gets destroyed. Also the user gets highlighted, @DepartureLV please still it to be better!

Card Link

https://3.basecamp.com/5802516/buckets/37608217/card_tables/cards/7498909855

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist before requesting a review

J-Ariola commented 1 month ago

You can open this PR again when you finish fixing the issue.

dominiksakic commented 1 month ago

@Flumanuck

  1. I got this error from the FRONTEND: The app didnt crash, and worked fine even though the error happened. Could we handle this error somehow?

  2. I logged in but there is too many users on the leaderboard already and I cant see my name. Could you make the leaderboard scrollable?

スクリーンショット 2024-06-16 13 04 25
Flumanuck commented 1 month ago

@dominiksakic I can take a look. I think I can make it scrollable. I'll look into the error too.

dominiksakic commented 1 month ago

Jacob is the leaderboard scrollable on your machine? On mine it isnt - I checked my local db and should have more users in the display

スクリーンショット 2024-06-16 16 24 12