search

PoignardAzur / venial

"A very small syn"
MIT License
196 stars 7 forks source link

venial v0.5 release #32

Closed Bromeon closed 2 years ago

Bromeon commented 2 years ago

Would it be possible to release a crates.io version some time in September?

There have been quite a few features going into venial since v0.4, and it would be nice if other published crates could make use of them. Personally I plan to release a first version of godot-rust (GDExtension) in the near future, and this is not possible on crates.io with Git dependencies.

Once everything becomes more stable and forward-compatibility is a topic, #[non_exhaustive] could be applied to structs/enums as well. This could also be done in a v0.6 after getting some feedback from v0.5 (which will likely lead to some breaking changes). In that light, I'd also argue it's better to get a version out soon, advertise it and collect user input, rather than trying to find the perfect API in the darkness 😉

One feature I still plan on implementing are traits. Should be relatively quick to do as a lot of the foundation is now built, but it might make sense to have mod support merged first (https://github.com/PoignardAzur/venial/pull/31).

PoignardAzur commented 2 years ago

Sorry for not getting back to you.

Yes, a new release makes sense. I'll give it my undivided attention on Thursday and we'll see it through.

PoignardAzur commented 2 years ago

Alright, I added you as a project owner to venial, so you should be available to publish by yourself.

I think we could apply the same "workflow" as for PRs: ping me before publishing a new version, and if I don't get back to you after a week, feel free to merge it yourself.

For this version, feel free to publish as soon as the problems I mentioned are fixed. (Or before that, if you're really time-constrained.)

Bromeon commented 2 years ago

Thanks a lot, appreciate the trust! ❤️

I'm not crazy time-constrained, so would appreciate to polish a few things with you before release. Maybe middle to end of October or so would be nice; I don't know about your availability though.

[Edit] If you don't want contributors to directly access crates.io, one option is publishing through CI, as I've implemented in godot-rust. But I realized you can only do this on a user level, not on a crate level; so security-wise it should ideally need a separate GitHub user. Just wanted to mention it, although I don't think it's needed right now -- publishing with a single crate is relatively simple.

PoignardAzur commented 2 years ago

New version released.

Bromeon commented 2 years ago

Very nice, thanks a lot for this! 👍

Do you want to make an announcement on Reddit/Twitter or so?

PoignardAzur commented 2 years ago

I'm not super invested either way.

Bromeon commented 2 years ago

I could also announce it 😉 but as you wish.

Mid-term, does it make sense if we look for other contributors/maintainers? I'm not sure I will have the capacity once the GDExtension/Rust port is available, as I expect lots of upcoming issues in the early phase. Plus, I also help maintain SFML...

PoignardAzur commented 2 years ago

(I noticed! Reading the SFML forums was a blast to the past. My posts from 2012 are still there!)

I'm not too worried about looking for maintainers. The userbase of the project is still tiny, and the project itself has a small enough surface area that I feel I should be able to fix bugs as they come up (with a bit of a delay).

If the project suddenly gets a popularity boost as more than a curiosity, then I expect more potential maintainers to show up.