PoignardAzur / venial

"A very small syn"
MIT License
196 stars 7 forks source link

Simplify often-used ident/punct parsers #34

Closed Bromeon closed 2 years ago

Bromeon commented 2 years ago

Builds on top of #33, which should be merged first

Relevant diff: here Relevant diff: c4499e9..397ed81

PoignardAzur commented 2 years ago

LGTM.

PoignardAzur commented 2 years ago

Longer review: this seems like a straight improvement that makes the code easier to read. The patch respects the naming scheme we discussed, which I definitely appreciate.

This is good to merge as soon as #33 is merged.

Bromeon commented 2 years ago

Rebased.

PoignardAzur commented 2 years ago

Feel free to merge this as soon as you've fixed merge conflicts.