Closed Bromeon closed 2 years ago
LGTM.
Longer review: this seems like a straight improvement that makes the code easier to read. The patch respects the naming scheme we discussed, which I definitely appreciate.
This is good to merge as soon as #33 is merged.
Rebased.
Feel free to merge this as soon as you've fixed merge conflicts.
Builds on top of #33, which should be merged first
Relevant diff: here
Relevant diff:c4499e9..397ed81