Have individual mods use default_stack_max instead explicitly using 99 as the stack_max

[Poikilos]

Setting stack_max explicitly is necessary in some cases to avoid being overridden, as seen with bread.

Instead of 99, they would have to use tonumber(minetest.settings:get("default_stack_max") or 99)

• tonumber can be skipped in cases where a stack string is being created but leaving it there won't hurt as long as the .. operator is used.

Affected code is found via cd bucket_game && grep "[^0-9a-zA-Z_]99[^0-9a-zA-Z]" -n -r --include \*.lua | grep -v max_drop_level | grep -v maxlevel | grep -v max_objects_per_block:

• [ ] mods/coderfood/unified_foods/foodcore.lua:305: stack_max = 99 , -- Set "stack_max" for object
• [ ] mods/coderfood/farming/crops/wheat.lua:111: stack_max = 99 ,
• [ ] mods/underground/caverealms/abms.lua:47: "default:torch 99",
• [ ] mods/coderbuild/christmas_craft/mod_files/items.lua:4:stack_max = 99,
• [ ] mods/coderbuild/christmas_craft/mod_files/items.lua:13:stack_max = 99,
• [ ] mods/coderbuild/christmas_craft/mod_files/multi-node.lua:162: stack_max = 99,
• [ ] mods/coderbuild/moreblocks/circular_saw.lua:99: if (not max or max < 1 or max > 99) then max = 99 end
• [ ] mods/coderbuild/moreblocks/circular_saw.lua:354: meta:set_string("max_offered", 99) -- How many items of this kind are offered by default?
• [ ] mods/coderbuild/redflowers/init.lua:21: stack_max = 99,
• [ ] mods/coderbuild/redflowers/init.lua:40: stack_max = 99,
• [ ] mods/coderbuild/bakedclay/init.lua:212: stack_max = 99,
• [ ] mods/coderbuild/coderblocks/air.lua:99: uses=99,
• [ ] mods/coderbuild/coderblocks/air.lua:127: damage_groups = {fleshy=99}
• [ ] mods/coderbuild/coderblocks/air.lua:166: damage_groups = {fleshy=99}
• [ ] mods/coderbuild/coderblocks/myretro.lua:135: output = '"myretro:sonic_grass" 99',
• [ ] mods/mtmachines/technic/items.lua:132: -- composition of 99.2837% U-238, 0.711% U-235, and 0.0053% U-234,
• [ ] mods/codercore/bucket/init.lua:255: stack_max = 99,
• [ ] mods/codercore/coderskins/init.lua:1054:"background[0.06,0.99;7.92,7.52;ui_misc_form.png]" ..
• [ ] mods/codercore/coderskins/init.lua:1083:if nspages > 99 then nspages = 99 end
• [ ] mods/codercore/coderskins/init.lua:1099:"background[0.06,0.99;7.92,7.52;ui_misc_form.png]"
• [ ] mods/codercore/codersea/shipwrecks.lua:46: main = {[1] = "default:tree 99", [2] = "default:jungletree 99", [3] = "default:wood 99", [4] = "default:junglewood 99", [5] = "default:sapling 99", [6] = "default:junglesapling 99", [7] = "default:grass_1 99", [8] = "default:junglegrass 99", [32] = ""}
• [ ] mods/codercore/codersea/shipwrecks.lua:102: main = {[1] = "default:gold_ingot 99", [2] = "default:mese_crystal 99", [3] = "default:diamond 99", [32] = ""}
• [ ] mods/codercore/craft_guide/api_craft_guide.lua:364: .."button[6.8,9.2;0.7,0.8;copy99;99]"
• [ ] mods/codercore/give_initial_stuff/init.lua:17: ",default:axe_steel,default:shovel_steel,default:torch 99" ..
• [ ] mods/codercore/give_initial_stuff/init.lua:18: ",default:cobble 99"
• [ ] mods/codercore/tsm_pyramids/mummy.lua:371: stack_max = 99,
• [ ] mods/codercore/unified_inventory/register.lua:323: .. "button[1.3," .. (formspecy + 2.7) .. ";0.8,0.5;craftguide_giveme_99;99]"
• [ ] mods/codercore/unified_inventory/register.lua:405: .. "button[1.3," .. (formspecy + 2.7) .. ";0.8,0.5;craftguide_giveme_99;99]"
• [ ] mods/codercore/unified_inventory/register.lua:456: if amount == 0 or amount < -1 or amount > 99 then return end
• [ ] mods/upper_realms/loud_walking/deco.lua:309: stack_max = 99,

[Poikilos]

In 211114a, the default:bread behaves as food, has the right recipe, and there is no duplicate, but the stack size is 3. Other stack sizes are 99 where listed in the issue. Only nodes not listed are 64 are ones that aren't listed on the issue.

As of bucket_game 211114a the he default_stack_max patch is not present (from 211111-bucket-game.pdf, tested successfully in 211111a, but not implemented in 211114a):

Add the lines below to "default/init.lua" right after the "dofile" line that loads "ocutil.lua":

local defstackmax = ocutil.numsetzero ("default_stack_max")
if defstackmax ~= 0 and
core.nodedef_default ~= nil then
core.nodedef_default.stack_max = defstackmax
end

-@OldCoder

Even if the patch above were added (it is not in 211114a), the changes in the checklist are still necessary because the existing code circumvents core.nodedef_default.stack_max by using 99 explicitly. However, instead of saying tonumber(minetest.settings:get("default_stack_max") or 99) you could probably just remove the stack_max from the node def as long as the "core.nodedef_default.stack_max patch" is done. It should work as long as done for all items in the checklist on the issue.

[Poikilos]

If basefoods or some other code redefines some sort of API function that any food mods call, and also sets the max where its version of the function, the issue will have to be addressed in the redefined function the same way it is addressed in the mods listed.