search

Poimen / stencil-tailwind-plugin

Plugin for using tailwindcss with StencilJS
https://www.npmjs.com/package/stencil-tailwind-plugin
MIT License
51 stars 5 forks source link

fix(sass): add support for sass syntax and update dependencies #18

Closed ohkimur closed 2 years ago

ohkimur commented 2 years ago

This PR fixes #17 issue.

ohkimur commented 2 years ago

@Poimen I fixed the sass syntax issue. If you want you can write some tests for it. I also noticed that when writing utility classes using @apply the HMR doesn't work properly (or something similar). The component is remounted but, the styles that are applied in the css/sass/scss file are not applied. What's interesting is that on page reload the code works as intended. So this should be further investigated.

ohkimur commented 2 years ago

@Poimen If everything is fine on your side, can you merge this into the main branch so that everybody can benefit from these minor fixes? I would need to use this in one of my projects also.

Poimen commented 2 years ago

Thanks for the contrib 👍

On the HMR issue, this is a bug bear - did the tailwindHMR() help at all? (https://github.com/Poimen/stencil-tailwind-plugin#hmr-considerations)

ohkimur commented 2 years ago

If I properly understand, at the moment tailwindHMR() only watches for the .tsx files. But, really it should also watch the CSS files. When using the @apply directive in the CSS files it should detect the changes and update the right module accodingly.

ohkimur commented 2 years ago

@Poimen I see the main-build is failing. Is there something I can do about that?

ohkimur commented 2 years ago

@Poimen Can we merge this into the main branch?

Poimen commented 2 years ago

Hi - sorry, I didn't get a notification message about your reply's 🙈 only got one now with your latest reply 😥 apologies for that.

So the build is failing on the npm ci command - so I'm guessing something to do with updates to packages.

If you revert those, we can merge...

Poimen commented 2 years ago

Released in 1.3.0