Use C++11 code instead of Boost in metslib

PointCloudLibrary / pcl

Point Cloud Library (PCL)

https://pointclouds.org/

Other

9.88k stars 4.61k forks source link

Use C++11 code instead of Boost in metslib #2954

Open SunBlack opened 5 years ago

SunBlack commented 5 years ago

Currently metslib of PCL requires boost, because of this commit https://github.com/PointCloudLibrary/pcl/commit/57ace9a92d1667eaa6193262032ff688e222ce0f. Even if we revert changes from there it won't compile, because metslib is using tr1 and not final C++11 standard and there is no update to this lib. So we should adjust code there.

SergioRAgostinho commented 5 years ago

We definitely need to adjust the code here, because the later versions of the library is GPL and ours is licenced under BSD. This is the first import into GitHub from of mets.h. It has a copyright from 2006-2008, ours has 2006-2012 and is under BSD. The commit message reads, "modified to use BSD". The author does seem to be affiliated with the project https://github.com/coin-or/metslib/graphs/contributors

Did the author waive the licence restrictions in order to be included in PCL? @taketwo @jspricke

taketwo commented 5 years ago

Given that the commit author is the author of Metslib, I guess he had legal rights to waive license restrictions.

:+1: for adjusting code.

stale[bot] commented 4 years ago

Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.