[apps] Shifty looking code in hand_scanner

PointCloudLibrary / pcl

Point Cloud Library (PCL)

https://pointclouds.org/

Other

9.91k stars 4.61k forks source link

[apps] Shifty looking code in hand_scanner #3674

Closed kunaltyagi closed 4 years ago

kunaltyagi commented 4 years ago

Is there a reason why vi_0 is conditionally re-assigned and others aren't? I've not seen the algo, but based on the diagram in the comment, I'd expect there to be changes in other vertex indices based on index used for vi_0

Originally posted by @kunaltyagi in https://github.com/PointCloudLibrary/pcl/pull/3665

Line 370 (post #3665 merge), 374 before

stale[bot] commented 4 years ago

Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.

kunaltyagi commented 4 years ago

Since we don't have any complaints, the code must be right (or unused)