Open kunaltyagi opened 4 years ago
There are much more of it:
Just care: Not all are completely equal
@kunaltyagi May I do this?
After #3885 is merged - yes ;-)
@SunBlack I didn't knew you were already working on it.
No, I'm not working on it. I'm just applying clang-format to apps and during this we detected this code duplication. But it makes no sense to work on it, as long the formatting is not merged, as you would get a big merge conflict.
@SunBlack Okay.
Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.
Hi guys @kunaltyagi @SunBlack, can I take this issue if it is still relevant? In case, do you want me to define the lambda every time it is called? What do you mean to fix the call-sites? Or should I declare it as it is callable multiple times? Can I assume the list above contains all the files to modify?
Just to be 100% sure, can you give me more details about point 2? Did you mean files with FPS_CALC
?
Should I create headers (if absent) specifically to hold the lambda function (like e.g. apps/include/pcl/apps/openni_passthrough.h)?
Convert macro
FPS_CALC
to lambda and fix the call-sites.Locations:
Originally posted by @kunaltyagi in https://github.com/PointCloudLibrary/pcl/pull/3885