PointCloudLibrary / pcl

Point Cloud Library (PCL)
https://pointclouds.org/
Other
10.01k stars 4.62k forks source link

fix - visualization haven't install header fiels #5920

Closed nocanstillbb closed 10 months ago

mvieth commented 10 months ago

@nocanstillbb Hi, could you please explain more? What specific problem does this fix? How can I reproduce the problem?

nocanstillbb commented 10 months ago

i can't reproduct that, but if i hadn't modify that , windows11 + pcl 1.13.1 + VTK 9.3 will not install visualization heder files folder, because HAVE_QVTK = flase both GUISupportQt or GUISupport will do instaall visualization header files now

i think that is becuase i passed evn VTK_DIR but VTK_AVAILABLE_COMPONENTS hadn't detect correctly on first time, so it clear HAVE_QTVTK variable , not becuase i fix it and each compilation takes a lot of my time, so i close this pr

elseif("GUISupportQt" IN_LIST VTK_AVAILABLE_COMPONENTS AND "RenderingQt" IN_LIST VTK_AVAILABLE_COMPONENTS)
  set(HAVE_QVTK TRUE)
  #PCL_VTK_COMPONENTS is used in the PCLConfig.cmake to refind the required modules.
  #Post vtk 9.0, only required libraries are linked against pcl_visualizer.
  #Subprojects need to manually link to VTK-QT libraries.
  list(APPEND PCL_VTK_COMPONENTS GUISupportQt)
else()
  unset(HAVE_QVTK)         #<<<<<<<<<<<<<<<<<<<<  
endif()