search

PointCloudLibrary / pcl

Point Cloud Library (PCL)
https://pointclouds.org/
Other
10.01k stars 4.62k forks source link

[tutorials] suppress cmake warning for find python/sphinx using cmake 3.27 or later #5924

Closed UnaNancyOwen closed 10 months ago

UnaNancyOwen commented 10 months ago

This change are suppresses warnings when the option to generate tutorials is enabled in CMake. Suppress CMake warning for find python/sphinx using CMake 3.27 or later. This is mainly relevant when generating the PCL All-in-one Installer or limited case to generate tutorials, and it doesn't affect many users.

mvieth commented 10 months ago

The CMake doc (https://cmake.org/cmake/help/latest/policy/CMP0148.html) mentions that the old behaviour is considered deprecated, so wouldn't it be better to replace find_package(PythonInterp) with find_package(Python) (if CMake version is at least 3.12) in FindSphinx.cmake?

UnaNancyOwen commented 10 months ago

@mvieth It seems like a good idea to me. I have confirmed that works correctory. I will push the commit with applied that idea. Thanks,