PointCloudLibrary / pcl

Point Cloud Library (PCL)
https://pointclouds.org/
Other
9.89k stars 4.61k forks source link

Fix ABI compatibility problems for 1.14.1 release #6017

Closed mvieth closed 5 months ago

mvieth commented 5 months ago

Partially revert https://github.com/PointCloudLibrary/pcl/pull/5974 and https://github.com/PointCloudLibrary/pcl/pull/5988 and https://github.com/PointCloudLibrary/pcl/pull/5907 After the 1.14.1 release, we can re-apply these changes. The ABI checker reported: The parameter file_name became passed in r12 register instead of r13. Applications will read the wrong memory block instead of the parameter value. and The parameter cloud_tgt_demean became passed in r12 register instead of r13. These changes are not super important, so I think it doesn't hurt to temporarily revert them to achieve 100% ABI compatibility between 1.14.0 and 1.14.1.