Remove Deprecated Code for 1.15.0 release

PointCloudLibrary / pcl

Point Cloud Library (PCL)

https://pointclouds.org/

Other

9.64k stars 4.59k forks source link

Remove Deprecated Code for 1.15.0 release #6040

Closed Shayril closed 1 month ago

Shayril commented 1 month ago

Fixes #6039

larshg commented 1 month ago

Looking good - however you need to remove them for the CMakelists.txt as well, ad it cant find them now they where removed. Ie. here https://github.com/PointCloudLibrary/pcl/blob/5373884dc7221afeb1488850f0040db816a22d30/apps/in_hand_scanner/CMakeLists.txt#L21

larshg commented 1 month ago

Some of the files you deleted, shouldn't be deleted. Ie. visualization/include/pcl/visualization/pcl_visualizer.h. Only a method inside the class are deprecated, not then entire file. There are multiple occurence like this, ie. mls.h.

larshg commented 1 month ago

Thank you @Shayril :+1: