Closed yshrsmz closed 6 years ago
finished implementation. Please take a look.
Any updates on this?
@yshrsmz Can u take a look at this? Thanks!
I'm going to resolve conflicts once @stevenroose review this PR and accept the base idea, as I'm still not sure if this is an acceptable fix for #131
This looks good! Apparently there is a merge conflict.
One thing that made it hard to review that would be a better idea in a future PR would be to not commit dartfmt changes with your actual changes. A single run of dartfmt before all the changes would have been fine.
Did some people try this out?
Whoops, I already went ahead and merged it from the command line. I wonder why this doesn't show as merged here now..
thanks for merging! I'm going to close this :)
Regarding dartfmt, will send a PR if there is no one when I wake up today(it's 0:30 in Japan)
131
Here's another take, based on feedbacks from last PR(#147)
This time, we can get algorithms like
final digest = Digest("SHA-1")
.