Open stevenroose opened 5 years ago
@stevenroose I had issues with the dart environment (mailed you about it) and couldn't get the test suite running, hence the tests were never run. I'll have a look and see if i can get them sorted out some time.
Yeah I made a commit removing some old unused packages that also broke the compilation on my machine. So now I can run them again.
Must have missed your e-mail. Usually better to create issues, I have filters for that :p
On Fri, Feb 22, 2019, 14:14 Duncan Hoggan <notifications@github.com wrote:
@stevenroose https://github.com/stevenroose I had issues with the dart environment (mailed you about it) and couldn't get the test suite running, hence the tests were never run. I'll have a look and see if i can get them sorted out some time.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PointyCastle/pointycastle/issues/173#issuecomment-466409879, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0F3El6WO8VmyGWJWXC-4k6FjxbyunUks5vP_tcgaJpZM4bFlEO .
I've checked the test and it is structured correctly the length warning is also correct. I will adjust the test data accordingly, won't be difficult, just need the correct input parameters. Also you did reply on the mail, your rules are working fine 😁.
It seems like they never worked in the first place.
@duncanhoggan, @rondluper could you guys take a look perhaps??