PointyCastle / pointycastle

Moved into the Bouncy Castle project: https://github.com/bcgit/pc-dart
MIT License
270 stars 76 forks source link

GitHub and pub.dev do not recognize license #211

Closed simc closed 4 years ago

simc commented 4 years ago

Would it be possible to reformat the license, so GitHub and pub.dev recognize it?

Edit: I think the URL would need to be in the copyright line.

stevenroose commented 4 years ago

Does pub.dev recognize/know the Bouncy Castle license? It's not one of the most common ones.

simc commented 4 years ago

It looks to me like a standard MIT license. I tried to move the URL to the first line and GitHub recognizes MIT.

stevenroose commented 4 years ago

This project just got relicensed a few weeks back away from MIT.

Here is the PR: https://github.com/PointyCastle/pointycastle/pull/207

simc commented 4 years ago

This is the current license:

Copyright (c) 2000 - 2019 The Legion of the Bouncy Castle Inc.
(https://www.bouncycastle.org)

Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
the Software without restriction, including without limitation the rights to
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
of the Software, and to permit persons to whom the Software is furnished to do
so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

This is the MIT license:

Copyright (c) [year] [fullname]

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

The only thing preventing GitHub from recognizing it is the URL in the second line. It would need to be moved to the first line.

This file pointycastle/licenses/LICENSE-BouncyCastle.html has the correct format.

simc commented 4 years ago

In this fork, I moved the URL to the first line and GitHub accepts it.

Their official license also has the URL in the first line.

stevenroose commented 4 years ago

e2c8b680ccc0149f3250433571354596b1df766b should fix this.

simc commented 4 years ago

Thank you!