MichielStock commented 3 years ago

ITSIN and OTSIN

Hi, I added the latest stuff given the published work on optimal transportation and information theory:

a thorough update of the information-theoretic indices;
adding a function optimaltransportation to reproduce everything relating to OT Everything is documented and tested.

It does not allow for fitting a utility matrix, since this would entail a whole range of dependencies and other issues that come with data fitting.

Checklist

[x] The code is covered by unit tests
- [x] Additional cases or module in test/...
- [x] Relevant lines in test/runtests.jl
[x] The code is documented
- [x] Docstrings written for every function
- [x] If needed, additional lines in docs/src/...
[x] All contributors have added their name and affiliation to .zenodo.json

Pinging @tpoisot

MichielStock commented 3 years ago

I guess the errors are due to using keywords directly, e.g. f(x;a=a) => f(x;a). Only allowed in later versions. Will fix tomorrow.

MichielStock commented 3 years ago

Hey @tpoisot, seems like the unit tests don't run automatically anymore. Works for me locally though.

tpoisot commented 3 years ago

Good catch - I'll investigate, I was planning to work on that tomorrow!

tpoisot commented 3 years ago

When #193 is merged, could you please rebase on main? I've already bumped the release number, so I'll merge and tag.

tpoisot commented 3 years ago

Alright @MichielStock - you can rebase on main, do not change the version number, and when this is merged I will tag the v0.5.0 release.

tpoisot commented 3 years ago

Oh nevermind there was a button to bring this branch up to speed.