search

PoisotLab / GBIF.jl

Functions and types to access GBIF data from Julia
https://ecojulia.github.io/GBIF.jl/latest/
Other
19 stars 4 forks source link

replace Nothing with Missing in GBIFrecord #11

Closed mkborregaard closed 5 years ago

mkborregaard commented 5 years ago

I've replaced Nothing with Missing in GBIFRecord because it actually is a case of missingness. It also leads to better behaviour when exporting to a DataFrame. I've carefully only changed the instances that actually do refer to missingness.

mkborregaard commented 5 years ago

The test error is due to the test/occurrence.jl file leading to a nonexisting url, so not related to the PR.

tpoisot commented 5 years ago

Working on it on dev -- the key GBIF used as an example now returns a 404, so I changed it.

tpoisot commented 5 years ago

Merged, thanks!