Paging after applying filters causes a bug in the number of records

PoisotLab / GBIF.jl

Functions and types to access GBIF data from Julia

https://ecojulia.github.io/GBIF.jl/latest/

Other

19 stars 4 forks source link

Paging after applying filters causes a bug in the number of records #15

Closed tpoisot closed 5 years ago

tpoisot commented 5 years ago

When calling qualitycontrol! followed by next!, the actual number of records is not counted correctly, which results in the wrong occurrences being returned. As the filters are not part of the GBIFRecords object (but this may be an improvement for a future version), the solution is most likely to call showall! when next! is called.

mkborregaard commented 5 years ago

In a sense qualitycontrol! is really just a synonym for filter!, right? Why not just use that?

tpoisot commented 5 years ago

I agree -- this is exactly what I'm doing at the moment!