PoisotLab / GBIF.jl

Functions and types to access GBIF data from Julia
https://ecojulia.github.io/GBIF.jl/latest/
Other
19 stars 4 forks source link

Tests for filtering sometimes fail #21

Closed tpoisot closed 4 years ago

tpoisot commented 5 years ago

My best guess as to why is: sometimes the most recent observations have no issues, and so the tests (which is testing the fact that the length before/after changes) are failing. This can be solved by putting a function which will remove some records e.g. at random, like f(g::GBIFRecord) = rand() < 0.5.

mkborregaard commented 5 years ago

will that not lead the tests to always pass?

tpoisot commented 5 years ago

The specific test is that after a filtering that removes some species, the length of the records object should be lower than before.