PoisotLab / SimpleSDMLayers.jl

Simple layers for species distribution modeling and bioclimatic data
https://docs.ecojulia.org/SimpleSDMLayers.jl/stable/
MIT License
19 stars 2 forks source link

Use missing instead of nothing in `DataFrame()` overload #105

Closed gabrieldansereau closed 3 years ago

gabrieldansereau commented 3 years ago

What the pull request does

As mentioned in #52, this replaces nothing elements by missing when converting a layer to a DataFrame, as missing has better support.

Type of change

Please indicate the relevant option(s)

Checklist

codecov-commenter commented 3 years ago

Codecov Report

Merging #105 (89beeaf) into master (f27ea63) will increase coverage by 0.21%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   80.02%   80.23%   +0.21%     
==========================================
  Files          24       24              
  Lines         756      759       +3     
==========================================
+ Hits          605      609       +4     
+ Misses        151      150       -1     
Flag Coverage Δ
unittests 80.23% <100.00%> (+0.21%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SimpleSDMLayers.jl 92.30% <ø> (ø)
src/integrations/DataFrames.jl 100.00% <100.00%> (+1.51%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f27ea63...89beeaf. Read the comment docs.