PoisotLab / SimpleSDMLayers.jl

Simple layers for species distribution modeling and bioclimatic data
https://docs.ecojulia.org/SimpleSDMLayers.jl/stable/
MIT License
19 stars 2 forks source link

Various quality of life improvements #50

Closed tpoisot closed 3 years ago

tpoisot commented 3 years ago

What the pull request does

Type of change

Please indicate the relevant option(s)

Checklist

codecov-io commented 3 years ago

Codecov Report

Merging #50 (f899850) into master (1a41008) will increase coverage by 1.29%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   85.75%   87.05%   +1.29%     
==========================================
  Files          17       17              
  Lines         344      363      +19     
==========================================
+ Hits          295      316      +21     
+ Misses         49       47       -2     
Flag Coverage Δ
unittests 87.05% <100.00%> (+1.29%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/datasets/geotiff.jl 100.00% <100.00%> (ø)
src/lib/overloads.jl 94.44% <100.00%> (+4.30%) :arrow_up:
src/recipes/recipes.jl 88.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a41008...8b3df35. Read the comment docs.

tpoisot commented 3 years ago

@gabrieldansereau you might be right - I think we can remove it and use an iterator as suggested by @mkborregaard in #51, to do something with findall instead. I should be able to remove it without too much trouble.