Closed gottacatchenall closed 3 years ago
Here's my unsollicited review:
Turing
and StatsFuns
to the docs/Project.toml
(alternatively it's probably better to rewrite logistic
, it's a one-liner)Project.toml
I love the example, I'll have more feedback when the issues raised in #59 are solved (later tonight)
sounds good, i'll make those changes and hopefully add some more text explaining whats happening tonight/tomorrow
It would be cool to use the same occurrences across all examples, I think - I'm changing #61 to use the data from https://jcoliver.github.io/learn-r/011-species-distribution-models.html -- there's not too many points, and the spatial scale is relatively small
I'm just going to make this catch up with master
I'm also going to do a bunch of edits to make sure it follows the conventions of the package and other example
Here's an output -- will push my code soon
I am sub-sampling a little bit because running the chains takes a little time, and the github actions VMs are not going to like that.
And with this last commit, the example should run -- I'll let you add some text, etc. I might add another example using Flux where we sample the negatives within a radius around observations, that might be fun to write.
Hmmmm.... we might have to scale this example down to get it to run in a reasonable amount of time. I'll think about something suitable.
the saguaro data covers a much smaller spatial extent which could speed things up, and currently i'm using MvNormal
and fitting all layers of worldclim (basically trying to overfit), which i think would be faster with fewer variables and a Normal
for each
What about the Corsican nuthatch? It's very limited in space (to Corsica), do we have enough observations on GBIF?
Corsican nuthatch runs pretty fast even with all predictors. Added some text, might add more later
So this apparently times out. Is the example so large?
One thing I had to do for the Mangal documentation was to have Weave documents, which we can run in parallel, for the most intensive tasks.
Weaving might be necessary as any other examples are likely to be more complex and slower, I can implement the changes from above and try that later
or.... we can make a repo for vignettes? Let's take a few days to think about it.
Alternatively, what do you think about getting some examples from Berteaux's book? They mostly use bioclim 1 and 12, and we can still do some work with two predictors for now.
that works, also Fletcher&Fortin 2019 have a lot of examples and data sets with implementations in R, wouldn't be hard to port them
Codecov Report
84.69% <50.00%> (-0.61%)
Flags with carried forward coverage won't be shown. Click here to find out more.
90.62% <42.85%> (-3.76%)
93.10% <100.00%> (ø)
Continue to review full report at Codecov.