PojavLauncherTeam / PojavLauncher

A Minecraft: Java Edition Launcher for Android and iOS based on Boardwalk. This repository contains source code for Android platform.
GNU Lesser General Public License v3.0
6.66k stars 1.27k forks source link

[BUG] Buttons with 0 height or 0 width will not be deleted before the controlmap is saved. #5557

Open Muggle2077 opened 3 months ago

Muggle2077 commented 3 months ago

Describe the bug

Buttons with 0 height or 0 width will not be deleted before the controlmap is saved.

The log file and images/videos

No.

Steps To Reproduce

1. Open the PojavLauncher.
2. Click on "CUSTOM CONTROLS".
3. Add some buttons and change their sizes to 0.0 x 100.0 or 100.0 x 0.0.
4. Save.

You will see that those buttons with 0 height or 0 width is saved. And if you want to modify the controlmap again, you can't select them anymore and if you try to add some other buttons, those buttons will affect their alignments.

Expected Behavior

Buttons with 0 height or 0 width should be deleted before the controlmap is saved.

Platform

- PojavLauncher version: edelweiss-20240531-bdc7f33-v3_openjdk

Anything else?

I have no idea about whether it is intended. You can delete those buttons by editing the json file. So, it might be of low priority.

Mathias-Boulay commented 3 months ago

ok fair.