search

PojavLauncherTeam / PojavLauncher

A Minecraft: Java Edition Launcher for Android and iOS based on Boardwalk. This repository contains source code for Android platform.
GNU Lesser General Public License v3.0
6.87k stars 1.29k forks source link

[BUG] Two arguments merge into one #6301

Closed aceinetx closed 3 days ago

aceinetx commented 4 days ago

Describe the bug

The java/minecraft arguments that require a value will merge into one, for example: --version 1.16.5 becomes --version1.16.5

The log file and images/videos

--------- Starting game with Launcher Debug!
Info: Launcher version: foxglove-20241119-a5d02c1-v3_openjdk
Info: Architecture: arm
Info: Device model: Xiaomi Redmi 9C
Info: API version: 30
Info: Selected Minecraft version: 1.16.5
Info: Custom Java arguments: "--version 1.16.5 --accessToken 0"
--------- beginning of main

Added custom env: TMPDIR=/data/user/0/net.kdt.pojavlaunch/cache
Added custom env: AWTSTUB_WIDTH=1600
Added custom env: FORCE_VSYNC=false
Added custom env: POJAV_NATIVEDIR=/data/app/~~fYTCPo5toybkXx87kofkng==/net.kdt.pojavlaunch-Etx_zhml5UxUTce8bu7syA==/lib/arm
Added custom env: LIBGL_MIPMAP=3
Added custom env: allow_higher_compat_version=true
Added custom env: MESA_GLSL_CACHE_DIR=/data/user/0/net.kdt.pojavlaunch/cache
Added custom env: HOME=/storage/emulated/0/Android/data/net.kdt.pojavlaunch/files
Added custom env: PATH=/data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/bin:/sbin:/system/sbin:/product/bin:/apex/com.android.runtime/bin:/system/bin:/system/xbin:/odm/bin:/vendor/bin:/vendor/xbin
Added custom env: LIBGL_NOINTOVLHACK=1
Added custom env: force_glsl_extensions_warn=true
Added custom env: LIBGL_NORMALIZE=1
Added custom env: POJAV_VSYNC_IN_ZINK=1
Added custom env: LD_LIBRARY_PATH=/data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/jli:/data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib:/system/lib:/vendor/lib:/vendor/lib/hw:/data/app/~~fYTCPo5toybkXx87kofkng==/net.kdt.pojavlaunch-Etx_zhml5UxUTce8bu7syA==/lib/arm
Added custom env: LIBGL_NOERROR=1
Added custom env: POJAV_RENDERER=opengles2
Added custom env: LIBGL_ES=2
Added custom env: VTEST_SOCKET_NAME=/data/user/0/net.kdt.pojavlaunch/cache/.virgl_test
Added custom env: MESA_LOADER_DRIVER_OVERRIDE=zink
Added custom env: JAVA_HOME=/data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz
Added custom env: allow_glsl_extension_directive_midshader=true
Added custom env: AWTSTUB_HEIGHT=720
Initialising gl4es
v1.1.5 built on Jul 14 2024 19:36:39
Using GLES 2.0 backend
loaded: libGLESv2.so
loaded: libEGL.so
Using GLES 2.0 backend
Hardware Full NPOT detected and used
Extension GL_EXT_blend_minmax  detected and used
Extension GL_EXT_draw_buffers  detected and used
FBO are in core, and so used
PointSprite are in core, and so used
CubeMap are in core, and so used
BlendColor is in core, and so used
Blend Subtract is in core, and so used
Blend Function and Equation Separation is in core, and so used
Texture Mirrored Repeat is in core, and so used
Extension GL_OES_mapbuffer  detected
Extension GL_OES_element_index_uint  detected and used
Extension GL_OES_packed_depth_stencil  detected and used
Extension GL_OES_depth24  detected and used
Extension GL_OES_rgb8_rgba8  detected and used
Extension GL_EXT_multi_draw_arrays  detected
Extension GL_EXT_texture_format_BGRA8888  detected and used
Extension GL_OES_depth_texture  detected and used
Extension GL_OES_texture_stencil8  detected and used
Extension GL_EXT_texture_rg  detected and used
Extension GL_OES_texture_float  detected and used
Extension GL_OES_texture_half_float  detected and used
Extension GL_EXT_color_buffer_float  detected and used
Extension GL_EXT_color_buffer_half_float  detected and used
Extension GL_OES_fragment_precision_high  detected and used
Extension GL_EXT_shader_texture_lod detected and used
Max vertex attrib: 16
Extension GL_OES_standard_derivatives  detected and used
Extension GL_OES_get_program_binary  detected and used
Number of supported Program Binary Format: 1
Max texture size: 4096
Max Varying Vector: 15
Texture Units: 16/16 (hardware: 16), Max lights: 8, Max planes: 6
Hardware vendor is Imagination Technologies
GLSL 300 es supported
GLSL 310 es supported and used
GLSL 320 es supported
Max Color Attachments: 8 / Draw buffers: 8
sRGB surface supported
EGLImage to Texture2D supported
EGLImage to RenderBuffer supported
ignore MipMap
glGetError() always return GL_NOERROR
Targeting OpenGL 2.1
No hack in shader converter to define overloaded function with int
Not trying to batch small subsequent glDrawXXXX
try to use VBO
FBO workaround for using binded texture enabled
Force texture for Attachment color0 on FBO
Hack to trigger a SwapBuffers when a Full Framebuffer Blit on default FBO is done
Force normals to be normalized on FPE shaders
glX Will try to recycle EGL Surface
Current folder is:/
I/jrelog  (24589): dlopen libgl4es_114.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libjli.so success

I/jrelog  (24589): dlopen libjvm.so failed: dlopen failed: library "libjvm.so" not found

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/server/libjvm.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libverify.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libjava.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libnet.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libnio.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libawt.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libawt_headless.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libfreetype.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libfontmanager.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libnet.so success
I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libawt_headless.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libjaas.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libfontmanager.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/librmi.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libprefs.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libextnet.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libmanagement_ext.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libjava.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libattach.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libmanagement.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libjavajpeg.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libj2pcsc.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libj2pkcs11.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libj2gss.so success
I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libnio.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libinstrument.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libdt_socket.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libsyslookup.so success
I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libverify.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libjimage.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/server/libjvm.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/server/libjsig.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libjsig.so success
I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libjli.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libfreetype.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/liblcms.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libjawt.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libawt.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libzip.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libmanagement_agent.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libmlib_image.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libjdwp.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libsctp.so success

I/jrelog  (24589): dlopen /data/user/0/net.kdt.pojavlaunch/runtimes/jre17-arm-20210914-release.tar.xz/lib/libawt_xawt.so success

I/jrelog  (24589): dlopen /data/app/~~fYTCPo5toybkXx87kofkng==/net.kdt.pojavlaunch-Etx_zhml5UxUTce8bu7syA==/lib/arm/libopenal.so success

I/jrelog  (24589): Done processing args

I/jrelog  (24589): Found JLI lib

I/jrelog  (24589): Calling JLI_Launch

Unrecognized option: --version1.16.5
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

Steps To Reproduce

1. Add --version 1.16.5 or any other arguments that require a value into the jvm arguments
2. Launch the game

Expected Behavior

I except the game to be launched with the correct argument placement

Platform

- Device model: Redmi 9C NFC
- CPU architecture: armv8l (armv7)
- Android version: 11 (Modified pixel experience rom)
- PojavLauncher version: foxglove-20241119-a5d02c1-v3_openjdk

Anything else?

In the logs that I provided the jvm arguments in the beginning are displayed perfectly fine, so it may or may not be an issue with minecraft

artdeell commented 4 days ago

the arguments box in the launcher is for JVM arguments, not for Minecraft arhumentc (which is what you are specifying)

aceinetx commented 4 days ago

the arguments box in the launcher is for JVM arguments, not for Minecraft arhumentc (which is what you are specifying)

I don't think that's the reason, there is no specific way to specify minecraft arguments (at least to my knowledge). On windows the --version argument can be placed alongside -Xms or any other java argument and it'll work fine. So I see no reason why I can't do the same on pojavlauncher

artdeell commented 4 days ago

Yes, there is no specific way to specify minecraft arguments as we didn't implement it. You can't do the same on PojavLauncher because we send all arguments specified in "JVM arguments" or "JVM Launch arguments" to the JVM, not to Minecraft itself.

My question is: waht are you attempting to do? Log in without a token? You can do that by using a local account.

aceinetx commented 3 days ago

Yes, there is no specific way to specify minecraft arguments as we didn't implement it. You can't do the same on PojavLauncher because we send all arguments specified in "JVM arguments" or "JVM Launch arguments" to the JVM, not to Minecraft itself.

My question is: waht are you attempting to do? Log in without a token? You can do that by using a local account.

Just trying to run a custom .jar (Mostly i'm just experimenting). Ignore the --accessToken, minecraft really needs it for some reason