search

PokeAPI / pokeapi.co

The PokéAPI documentation website
https://pokeapi.co
BSD 3-Clause "New" or "Revised" License
136 stars 52 forks source link

Drop node-gyp dependency #110

Closed Naramsim closed 2 years ago

Naramsim commented 2 years ago

node-gyp is a transitive dependency, brought in by a small plugin that created favicons.

This package is a hassle to install in most systems and heavily pollutes the workstation. For example, on Win10 you need to have Microsoft's Win10SDK and Python installed. I see more downsides than upsides having it. I thus removed react-static-plugin-favicons and node-sass which depend on it.

Naramsim commented 2 years ago

@cmmartti, do you see any benefits in this PR? I'd like a review. Thanks