search

PokeAPI / pokeapi

The Pokémon API
https://pokeapi.co
BSD 3-Clause "New" or "Revised" License
4.05k stars 921 forks source link

Update machines #1091

Closed edenbynever closed 1 month ago

edenbynever commented 1 month ago

This patch hopefully brings PokeAPI's information regarding machines up to date.

For BDSP, there's only minor variation from Diamond and Pearl, but I went ahead and scripted the process anyway to try to ensure that my first contribution to the project didn't contain any errors.

I couldn't find any information regarding how best to add new items, but I figured it made sense enough to auto-increment from just before the ones with "weird" IDs.

I wanted quite badly to sort machines.csv by generation rather than TM number before updating it, but I settled for just sorting my additions that way, mostly in the interest of localizing the changes, and that in order to preempt the likely discovery of more new machines in Teal Mask.

I'm probably missing something somewhere, but this should get us most of the way toward closing #1029.

Naramsim commented 1 month ago

Thanks a lot! Contributions are much appreciated!

pokeapi-machine-user commented 1 month ago

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user commented 1 month ago

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).