search

PokeAPI / pokeapi

The Pokémon API
https://pokeapi.co
BSD 3-Clause "New" or "Revised" License
4.05k stars 921 forks source link

fix(openapi): use correct tag type, maintain operation order #1092

Closed Indyandie closed 1 month ago

Indyandie commented 1 month ago

Related to #1087

Naramsim commented 1 month ago

Hi, my question was a bit different.

Is it possible not to write a hardcoded string but to fetch the descriptions with code from the api.py file? I see that settings.py is a Python file, so it should be possible to write Python code and maybe import the api.py file and get the descriptions.

Indyandie commented 1 month ago

@Naramsim I see... that sounds pretty doable but I'm total python noob 🤓. I think the duplication is okay in this instance since tags and operations are distinct concepts.

Naramsim commented 1 month ago

Ok! I'll merge this PR, but if you have time and will maybe you can look into how to dynamically get the description

pokeapi-machine-user commented 1 month ago

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user commented 1 month ago

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).