PokeAPI / pokeapi

The Pokémon API
https://pokeapi.co
BSD 3-Clause "New" or "Revised" License
4.05k stars 921 forks source link

Update encounter_method_prose.csv #1094

Closed DanielSmith13 closed 1 month ago

DanielSmith13 commented 1 month ago

Removed duplicate references for Encounter Method 22 French language

Testing: Call https://pokeapi.co/api/v2/encounter-method/22 endpoint, the French translation should now only be included once

edenbynever commented 1 month ago

You're right that the 22,5 tuple is incorrectly repeated twice, but they're not complete duplicates. The fix isn't to remove them, but rather to correct the numbering:

23,9,Headbutting a normal encounter rate tree
- 22,5,En utilisant Coup d’Boule sur un arbre à taux normal
+ 23,5,En utilisant Coup d’Boule sur un arbre à taux normal
24,9,Headbutting a high encounter rate tree
- 22,5,En utilisant Coup d’Boule sur un arbre à taux élevé
+ 24,5,En utilisant Coup d’Boule sur un arbre à taux élevé
DanielSmith13 commented 1 month ago

Ah yes, you are right, modified this now, also noticed that the data/v2/csv/encounter_condition_value_prose.csv had the values for arceus in party incorrectly linked to condition 10, when I assume they are supposed to reference encounter condition 71

Naramsim commented 1 month ago

Thanks to both of you! I merge

pokeapi-machine-user commented 1 month ago

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user commented 1 month ago

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).