search

PokeAPI / pokeapi

The Pokémon API
https://pokeapi.co
BSD 3-Clause "New" or "Revised" License
4.41k stars 957 forks source link

Duplicate entry for Malie-City in locations.csv #1097

Open O-Tahmas opened 6 months ago

O-Tahmas commented 6 months ago

Hi!

I've noticed that on locations data - https://pokeapi.co/api/v2/location - all generation + name combinations are unique except for id=768 and id=1045

https://pokeapi.co/api/v2/location/768 https://pokeapi.co/api/v2/location/1045

Both are malie-city entries and I'm not sure how they differ. I've opened a PR that proposes to delete out location/1045 , by doing so all (region_id , identifier) are unique in locations.csv , as currently the only dupe pair is the above, which does lead me to believe its a duplicate data entry.

Thanks, Omar

edenbynever commented 6 months ago

Both are malie-city entries and I'm not sure how they differ.

The handful of region 7 entries at the end of locations.csv are intended to refer to their manifestations in Ultra Sun/Moon, and they do all appear to be distinct from their corresponding Sun/Moon entries, with the differences having to do with the Pokémon available to catch and/or the trainers available for battle.

malie-city is the only one that tripped your uniqueness check because the others have specific areas tacked on in the Sun/Moon case (cf. hauoli-city vs. hauoli-city--marina).

I suppose the fix would be to change the region column to (or add) a version column. It's not clear whether that would be worthwhile for just these few locations, but it may be the case that there are plenty of others to which this distinction would apply.

Renaming id=768 to malie-city--proper seems like a decent middle-of-the-road solution.

O-Tahmas commented 6 months ago

Thanks, and makes sense on the possible can-of-worms!

I've taken your suggestion and opened a PR renaming id=768 to malie-city--proper