search

PokeAPI / pokeapi

The Pokémon API
https://pokeapi.co
BSD 3-Clause "New" or "Revised" License
4.41k stars 957 forks source link

Modify Japanese data for Pokémon 960 and add Korean data, add missing Korean data(899 ~ 1025), add new Pokémon 1025 Korean data #1123

Closed BearHumanS closed 3 months ago

BearHumanS commented 3 months ago

Summary

This pull request contains some important updates and modifications to Pokémon data.

Changes made to:

  1. Correction of Japanese data:

    • Issue: Korean species name of Pokémon 960 is incorrectly recorded in Japanese.
    • Fix: We modified the Japanese data of Pokémon 960 from that dataset and added Korean data.

  2. Added missing Korean data:

    • Issue: Some Korean names of Pokémon species are missing. 899 to 1025
    • Update: Added missing Korean names to the Pokémon Species dataset.

  3. Add new Pokemon data:

    • Issue: Korean name and species of Pokémon 1025 are missing.
    • Update: Added Korean name and species for Pokémon 1025.

Updated files:

Reasons for change

These updates improve the accuracy of Pokémon data and ensure that all related names are available to both Korean and Japanese users. The addition of Pokémon 1025 keeps the dataset up to date with new entries.

Test

Additional Notes

스크린샷 2024-08-30 192153 image image image

Naramsim commented 3 months ago

Thanks a lot for the PR! I'll look into it!

BearHumanS commented 3 months ago

Thanks a lot for the PR! I'll look into it!

I'm happy to be able to contribute a little to this.

pokeapi-machine-user commented 3 months ago

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user commented 3 months ago

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).