search

PokeAPI / pokeapi

The Pokémon API
https://pokeapi.co
BSD 3-Clause "New" or "Revised" License
4.41k stars 957 forks source link

Fixed Shape IDs for Gen IX Pokémon #1127

Closed erezushi closed 2 months ago

erezushi commented 2 months ago

Fixed shape IDs for Gen IX Pokémon, according to the filters on the mobile version of Pokémon HOME

Naramsim commented 2 months ago

Hi! Is it possible for a pokemon to have different shapes for different games?

erezushi commented 2 months ago

So far, there were only 12 Pokémon that had their shape change between games, 11 changed in XY, 1 in ORAS, so basically yes, but it's rare. What is possible is different forms having different shapes. Specifically in Gen IX, you have a difference between Zero and Hero Palafin, Chest and Roaming Gimmighoul, and between regular Terapagos and its other forms. Here I went with their "default" forms

Naramsim commented 2 months ago

Ok, so we would need a changelog table here as well. Maybe you can open an issue documenting it and maybe someone will work on it.

Naramsim commented 2 months ago

In the meantime I'll merge the PR.

pokeapi-machine-user commented 2 months ago

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user commented 2 months ago

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).