PokeAPI / pokeapi

The Pokémon API
https://pokeapi.co
BSD 3-Clause "New" or "Revised" License
4.41k stars 957 forks source link

Add legends pokemon arceus pokemon moves scrapped from serebii.net #1149

Closed programgames closed 1 month ago

programgames commented 1 month ago

Original PR #1132

Naramsim commented 1 month ago

You need to run black ., there's a file that needs formatting

programgames commented 1 month ago

Yeah, I know , but black doesn't format anything :

All done! ✨ 🍰 ✨ 37 files left unchanged

Maybe it is because i run it on Windows .

Naramsim commented 1 month ago

Ah, on my side I have changes. I think that maybe it's the version you are using

Naramsim commented 1 month ago

If I recall well you should remove a newline in the migrations file.

programgames commented 1 month ago

Ok thank you, that was the black version I used, before using the version specified in test-requirements.txt i tested on docker/linux, windows, nothing changed :)

Naramsim commented 1 month ago

Nice! Finally it got merged! Thanks a lot for the efforts!

pokeapi-machine-user commented 1 month ago

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user commented 1 month ago

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).