search

PokeAPI / pokeapi

The Pokémon API
https://pokeapi.co
BSD 3-Clause "New" or "Revised" License
4.41k stars 957 forks source link

fix #1067: Icy Snow Vivillon incorrect image #1159

Closed rayusagi closed 3 weeks ago

rayusagi commented 1 month ago

Relates to #1067.

I opted for the solution suggested by @Deleca7755. It seemed like the easiest one and the original intended objective. The Meadow form is now the default one instead of the Icy Snow form. Consequently, almost all existing sprites don't need to be changed. There is only the default shiny one that points to the Icy Snow form. I initiated a PR to fix this aswell on the sprites project: https://github.com/PokeAPI/sprites/pull/157

pokeapi-machine-user commented 3 weeks ago

This Pull Request won't be deployed since the label no-deploy was found in its meta-data.

rayusagi commented 3 weeks ago

Thanks! However, why did you tag with 'no-deploy'? It's essential to be deployed since https://github.com/PokeAPI/sprites/pull/157 and https://github.com/PokeAPI/sprites/pull/155/ have been merged.

I see the latter PR removed a the 666-meadow.png sprite. Unfortunately, without this current fix, the API provides broken links here : https://pokeapi.co/api/v2/pokemon-form/666/ in sprites.front_default and sprites.front_shiny.

Making the meadow form the default one (what this PR does) should fix the issue and point towards https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/666.png that does exist.

Naramsim commented 3 weeks ago

Because I merged 2 pr and wanted the last one merged to be the only one deployed

rayusagi commented 3 weeks ago

Oh okay, good to know.