search

PokeAPI / pokeapi

The Pokémon API
https://pokeapi.co
BSD 3-Clause "New" or "Revised" License
4.05k stars 921 forks source link

Max chance not calculated correctly when accounting for dual slot #694

Open Hyreon opened 2 years ago

Hyreon commented 2 years ago

In Generation IV, diamond pearl and platinum, you can boost the encounter rate of certain Pokemon by using the dual slot method: https://bulbapedia.bulbagarden.net/wiki/Dual-slot_mode

Obviously, one cannot have multiple pokemon in the dual slot. However, the entry for Diglett lists its max_chance as if dual slots are mutually compatible. Its true best odds is 5% - 4% for anything other than LeafGreen, and 1% when not using the PokeRadar. It is listed as 21%.

My current project uses this API to calculate which games are required for which Pokemon. If this feature were not added, then I would have to manually calculate max_chance, including a dictionary of exclusive conditions and adding the one with the best %.

Naramsim commented 2 years ago

Hi, I saw all your issues. Thanks for pointing everything out but I don't think we have time to fix all these issues. We'll leave them here and maybe they'll be fixed in the future by some voluntary contributor or by Veekun releasing updated data.