search

PokeAPI / pokebase

Python 3 wrapper for Pokéapi v2
BSD 3-Clause "New" or "Revised" License
287 stars 54 forks source link

Cache location area encounters #12

Closed jrubinator closed 6 years ago

jrubinator commented 6 years ago

This caches location area encounters, per issue #10

There's some logic in here to make sure that https://github.com/PokeAPI/pokeapi/pull/335 doesn't have any impact here.

jrubinator commented 6 years ago

Hmmm, apparently I removed some cachedir-creating code. Looking into it.

GregHilmes commented 6 years ago

Thank you for your contribution @jrubinator, and your patients (sorry for the delay here). I'm currently making several big improvements under the hood of pokebase. Unfortunately this means the changes you suggested no longer make sense with the current code state, so I have to close this PR. However, in the coming commits I intend to add support for subresources from the API, so keep your eye out for those (I had no idea subresources were even a thing, thanks for calling that to my attention).

jrubinator commented 6 years ago

@GregHilmes - no problem! I look forward to seeing the enhancements :)