Improve CACHE dir handling, use XDG standard, fix whitespace and shebang

PokeAPI / pokebase

Python 3 wrapper for Pokéapi v2

BSD 3-Clause "New" or "Revised" License

285 stars 53 forks source link

Improve CACHE dir handling, use XDG standard, fix whitespace and shebang #3

Closed MestreLion closed 6 years ago

MestreLion commented 6 years ago

The goal is to use ~/.cache/pokebase instead of current ~/.pokebase, to avoid further cluttering $HOME with hidden dirs. For backward-compatibility purposes if the old location already exists use it instead, so the change will affect only new installs.

The other changes are mostly cosmetic and improved security when handling directory creation.

GregHilmes commented 6 years ago

I wanted to let you know I've seen your PR, but I currently can't take an in-depth look at the code. I certainly will when I get the time to. Overall, it looks like you've made some handy-dandy improvements, thanks very much! I intend to merge sometime soon, again, once I get the time to look through it.

MestreLion commented 6 years ago

No problem, take your time. Soon I'll post more PRs, mostly concerning encounters and improving performance. Btw, about encounters: what do you feel about a new "subresource" to handle things like Pokemon/123/encounters ?

jrubinator commented 6 years ago

Re: the subresource - I think I filed #10 for that.