search

PokeAPI / pokebase

Python 3 wrapper for Pokéapi v2
BSD 3-Clause "New" or "Revised" License
286 stars 53 forks source link

closes #53 dependencies bump #55

Closed DahanDv closed 8 months ago

DahanDv commented 8 months ago

As written in the issue log, the support for 3.6-7 is very limiting; hence so few version bumps are possible without running into dependencies nightmares.

DahanDv commented 8 months ago

@Naramsim Good to go by me.

Naramsim commented 8 months ago

Can you bump the version in the setup.py? And remove python 3.6 support?

DahanDv commented 8 months ago

Can you bump the version in the setup.py?

Sure

And remove python 3.6 support?

Do you mean the commit message? I overrode its content; I'll squash it fine? (not 100% sure I understand your intent)

Naramsim commented 8 months ago

Nono, I meant here:

version, bump to 1.4.0: https://github.com/PokeAPI/pokebase/blob/master/setup.py#L12

drop support: https://github.com/PokeAPI/pokebase/blob/master/setup.py#L23

DahanDv commented 8 months ago

Done! :D

Naramsim commented 8 months ago

Thanks!