search

PokeAPI / pokebase

Python 3 wrapper for Pokéapi v2
BSD 3-Clause "New" or "Revised" License
286 stars 53 forks source link

Inhance the CI publishing section #57

Open DahanDv opened 8 months ago

DahanDv commented 8 months ago

@Naramsim Hi there. Once you guys figure out the Pypi bureaucracy, I'd like to propose changing the CI and automating the publishing process.

The CI will be split to 2 scenarios:

  1. Push. Any push to any branch will trigger all the testing suites. Same goes for non-master PRs.
  2. when a PR gets merged into master and only into master an automatic process will bump the version and execute the Pypi publish command.

Let me know if this sounds, and if it is, when we can start work on to :)

Naramsim commented 8 months ago

Hi! @GregHilmes added the pokeapi account to his package, so I was able to publish 1.4.0, then 1.4.1 as well :)

We are ready! We can add a token in the secrets for publishing

DahanDv commented 8 months ago

@Naramsim Great! I admit this will be the first time I'll implement such a process on GitHub's action platform, so it may take a few days to figure out, give or take, depending on other occupations I have. Let's keep this issue as a thread if I need anything from you guys :)

Naramsim commented 8 months ago

Okok It'll be a learning experience!

I'll give you a thorough review 😁😁